Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

That issue mentions https://www.youtube.com/sw.js no longer containing something, but from what I see it still has the client version, so I presume it no longer has the API key and we used to get it from there.

It seems when logged in calling the URL returns different data. When logged out I only get

  self.addEventListener('install', event => {
    event.waitUntil(self.skipWaiting());
  });
  self.addEventListener('activate', event => {
    event.waitUntil(
      self.clients.claim().then(() => self.registration.unregister()));
  });

The issue says it wants to find way to get both client version and API key, but your PR only gets client version from what I can see.

API keys are not used anymore, see #1168.

Please add tests that prove that this works

Not quite sure what's the best way to test this, since the method is private and the public function that uses it still works, since it falls back to extracting the version from the HTML page?

The issue says it wants to find way to get both client version and API key, but your PR only gets client version from what I can see.

So given that I don't think this closes #872. Please correct me if I'm wrong.

It does. The InnerTube API doesn't require an API key for a few years now.

@FineFindus Ah okay my bad, I was logged in 🤦‍♂️. Thank you for this information

Not quite sure what's the best way to test this, since the method is private and the public function that uses it still works, since it falls back to extracting the version from the HTML page?

Okay I've looked at the surrounding code, I think not worth refactoring to be able to test this explicitly neither is it quick or straightforward to do so.

What we should have is a test specifically for getting client version that tests the contract of getting the client version, and tests each branch of the method, but that's prob too much for this PR.

Still need to update the mocks though.